Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update internal telemetry docs #6484

Conversation

jade-guiton-dd
Copy link
Contributor

@jade-guiton-dd jade-guiton-dd commented Mar 6, 2025

This PR in the Collector, which moves some internal Collector metrics from the basic level to normal, was recently merged and should be part of the next release (v0.122.0). This PR updates the docs related to internal telemetry to reflect this change, and should probably wait until the release of 0.122.0 on March 17 before being merged.

This PR also adds a note detailing the history of changes to these metrics' level. (This is the PR that initially restricted them to normal, and I believe this is the PR that accidentally moved them back to basic.)


Preview: https://deploy-preview-6484--opentelemetry.netlify.app/docs/collector/internal-telemetry/#lists-of-internal-metrics

@opentelemetrybot opentelemetrybot requested review from a team and atoulme and removed request for a team March 6, 2025 16:04
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by comment.

@opentelemetrybot opentelemetrybot requested a review from a team March 7, 2025 14:21
@jade-guiton-dd jade-guiton-dd marked this pull request as ready for review March 19, 2025 14:52
@jade-guiton-dd jade-guiton-dd requested a review from a team as a code owner March 19, 2025 14:52
@jade-guiton-dd
Copy link
Contributor Author

0.122.0 has been released, this is now unblocked.

@chalin chalin force-pushed the update-batch-processor-metrics-level branch from 7a3d2ca to c1bda57 Compare March 19, 2025 15:01
@opentelemetrybot opentelemetrybot requested a review from a team March 19, 2025 15:01
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiffany76 - did you want to give a final thumbs up?

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tiffany76 tiffany76 added this pull request to the merge queue Mar 20, 2025
Merged via the queue into open-telemetry:main with commit 7397b6d Mar 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants